fix: avoid race condition with queue termination#126
Merged
Annopaolo merged 1 commit intoastarte-platform:release-1.2from Mar 16, 2026
Merged
fix: avoid race condition with queue termination#126Annopaolo merged 1 commit intoastarte-platform:release-1.2from
Annopaolo merged 1 commit intoastarte-platform:release-1.2from
Conversation
as under the hood we're `call`ing vernemq's queue, it may happen
that we enter a race condition with the process' termination
from other sources, such as the device being disconnected
this issue was encountered in astarte's ci, where we disconnect the
device right before starting the device deletion
the `catch` is very conservative, in pracice the error was in the
form `{:normal, _}` in astarte's ci, but in theory all `normal` exit
statuses account for an `:ok` device disconnection. better safe than
sorry
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
requested review from
a team,
Annopaolo and
nedimtokic
and removed request for
a team
lusergit
approved these changes
Mar 13, 2026
nedimtokic
approved these changes
Mar 13, 2026
Annopaolo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as under the hood we're
calling vernemq's queue, it may happen that we enter a race condition with the process' termination from other sources, such as the device being disconnectedthis issue was encountered in astarte's ci, where we disconnect the device right before starting the device deletion
the
catchis very conservative, in pracice the error was in the form{:normal, _}in astarte's ci, but in theory allnormalexit statuses account for an:okdevice disconnection. better safe than sorry