fix: allow nested discriminated unions as they are supported in Zod v4#367
Merged
AGalabov merged 1 commit intoMar 20, 2026
Merged
Conversation
dirkluijk
changed the title
dirkluijk
force-pushed
the
support-discriminated-unions
branch
from
March 6, 2026 11:20
45f8650 to
a7ce3d0
Compare
Contributor
Author
|
Any chance to get this merged? It blocks me to migrate a specific project to |
Member
|
@dirkluijk sorry it took me so long to get to this. I think the PR looks good. However the pipeline tests are failing - please run the |
dirkluijk
force-pushed
the
support-discriminated-unions
branch
from
March 20, 2026 14:56
a7ce3d0 to
2318125
Compare
Contributor
Author
|
You’re welcome, no problem at all. I felt a bit hesitant to tag you earlier. I’ve fixed the lint issue! |
Member
|
@dirkluijk thank you once again |
Contributor
Author
|
Awesome!! |
This was referenced Mar 20, 2026
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #239.
I marked it as a fix rather than a feature, as I would consider this expected behavior with Zod v4, also didn't have to add additional logic other than removing an error message 🎉