Controller: Add -s option to snoop by channel name or unique ID. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new command line option boolean '-s' to change the meaning of <dialstring> from originating a call to a new destination, to instead snooping on an existing channel, either by channel name or unique ID. For example... $ bin/ari-transcriber -s 'PJSIP/7001-00000001' Big thanks to Voisonics for sponsoring this patch. Resolves: asterisk#21 UserNote: The ari-transcriber now takes an additional argument '-s' on the command line to allow snooping on any Asterisk channel.
|
Any plans to merge this? Sounds interesting! |
|
@hatemalimam Have you tested the new option? |
|
@gtjoseph I haven't tried the exact commit, since I have created my own module inspired by this repo. However the approach in the commit is valid and works perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command line option boolean '-s' to change the meaning of from originating a call to a new destination, to instead snooping on an existing channel, either by channel name or unique ID.
For example...
$ bin/ari-transcriber -s 'PJSIP/7001-00000001'
Big thanks to Voisonics for sponsoring this patch.
Resolves: #21
UserNote: The ari-transcriber now takes an additional argument '-s' on the command line to allow snooping on any Asterisk channel.