Add log-caller-id-name option to log Caller ID Name in queue log #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
phoneben
force-pushed
the
patch-1
branch
4 times, most recently
from
ef0d09c to
a3303be
Compare
phoneben
changed the title
jcolp
reviewed
Mar 19, 2025
phoneben
changed the title
Add log_cidname option to log Caller ID Name in queue log Fixes: #1133 UserNote:This patch adds a global configuration option, log_cidname, to queues.conf to control whether the Caller ID name is logged as parameter 4 when a call enters a queue. With log_cidname=yes, the queue log entry will include the URL (if specified), the caller ID number, the queue position, and—if allowed by the existing log_restricted_caller_id rules—the caller ID name. Any '|' characters in the caller ID name will be replaced with '_'. With log_cidname=no (the default), only the URL, caller ID number, and queue position are logged. Accordingly, the documented log format has been updated to: ENTERQUEUE(url|callerid|queue_position[|calleridname])
|
i updated so it should be as the orig pr now . |
jcolp
reviewed
Mar 28, 2025
seanbright
requested changes
Apr 12, 2025
phoneben
changed the title
Add log-caller-id-name option to log Caller ID Name in queue log Fixes: #1133 UserNote:This patch adds a global configuration option, log-caller-id-name, to queues.conf to control whether the Caller ID name is logged as parameter 4 when a call enters a queue. With log-caller-id-name=yes, the queue log entry will include the URL (if specified), the caller ID number, the queue position, and—if allowed by the existing log_restricted_caller_id rules—the caller ID name. Any '|' characters in the caller ID name will be replaced with '_'. With log-caller-id-name=no (the default), only the URL, caller ID number, and queue position are logged. Accordingly, the documented log format has been updated to: ENTERQUEUE(url|callerid|queue_position[|calleridname])
jcolp
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add log-caller-id-name option to log Caller ID Name in queue log
Fixes: #1133
UserNote:This patch adds a global configuration option, log-caller-id-name, to queues.conf to control whether the Caller ID name is logged as parameter 4 when a call enters a queue. With log-caller-id-name=yes, the queue log entry will include the URL (if specified), the caller ID number, the queue position, and—if allowed by the existing log_restricted_caller_id rules—the caller ID name. Any '|' characters in the caller ID name will be replaced with '_'.
With log-caller-id-name=no (the default), only the URL, caller ID number, and queue position are logged. Accordingly, the documented log format has been updated to:
ENTERQUEUE(url|callerid|queue_position[|calleridname])