Migrate linting workflow to ruff check/format #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
ruff
branch
4 times, most recently
from
eff3292 to
0924d3c
Compare
Contributor
Author
|
Okay, that fixes up and modernizes formatting and linting. PTAL. |
- Upgrades the linting target version to 3.9, the latest non-eol python - Runs the CI under the latest stable, Python 3.13 - Migrates to `ruff check` to replace `flake8` - Migrates to `ruff format` to replace `black` - Ignore Jupyter Notebooks for now - Removes the W503/504 checks from ignore, as ruff does not support them
Contributor
|
Thanks ! Why ruff over black ? |
Contributor
Author
|
The formatting that ruff provides should mostly be compatible with black, but beyond that all the projects created by astral.sh (uv, ruff) are faster and more modern. |
Contributor
Author
|
Anything else? |
Contributor
|
Sorry, but asteroid follows black as well, we won't switch to ruff right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff checkto replaceflake8ruff formatto replaceblackMoved the fixes into dedicated commits, so you can reproduce them.