Skip to content

Conversation

@divyam234
Copy link

added some missing functions

Copy link
Owner

@asticode asticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ❤️

A few additions are needed 👍

}

// https://ffmpeg.org/doxygen/7.0/group__lavc__misc.html#gaf60b0e076f822abcb2700eb601d352a6
func (cc *CodecContext) FlushBuffers() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some test?

Just calling this new method here without checking anything should validate it doesn't crash 👍

}

// https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30
func (fc *FormatContext) SeekFile(streamIndex int, mints, timestamp, maxts int64, f SeekFlags) error {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests below this?

import "C"

// https://ffmpeg.org/doxygen/7.0/group__lavu__math.html#ga3daf97178dd1b08b5e916be381cd33e4
func Rescale(a, b, c int64) int64 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests above this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants