Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Ensure that bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy #15784

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[red-knot] Ensure that bool | AlwaysFalsy is considered equivalent to Literal[True] | AlwaysFalsy #15784

wants to merge 5 commits into from
+266 −178

Conversation

AlexWaygood
Copy link
Member

Summary

This PR is yet another alternative to #15738 and #15773.

I'll writeup a fuller PR summary once I've seen the benchmark results...

Test Plan

@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Jan 28, 2025
@AlexWaygood AlexWaygood force-pushed the alex/truthy-unions-7 branch 2 times, most recently from d7082e4 to e4a7142 Compare January 28, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexWaygood