[ty] Refactor index methods to parameterize scope#23394
Open
charliermarsh wants to merge 1 commit intomainfrom
Open
[ty] Refactor index methods to parameterize scope#23394charliermarsh wants to merge 1 commit intomainfrom
charliermarsh wants to merge 1 commit intomainfrom
Conversation
charliermarsh
added
internal
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
|
Memory usage reportMemory usage unchanged ✅ |
AlexWaygood
approved these changes
Feb 18, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I wonder if we could use IndexVecs with FileScopeIds as the indexes instead of Vecs for SemanticIndexBuilder::scope_stack and the inner data in TryNodeContextStackManager? then we would be able to pass around FileScopeIds instead of usizes, which would be more strongly typed
Contributor
|
I would like to take some time to understand how this is used in the walrus scope diff before we land it. |
Member
Author
|
Yup no worries, wasn't planning to merge before that's approved. |
charliermarsh
force-pushed
the
charlie/ref
branch
from
f63f6bb to
371d9fc
Compare
charliermarsh
force-pushed
the
charlie/ref
branch
from
371d9fc to
2e2938c
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 41 | 0 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
charliermarsh
force-pushed
the
charlie/ref
branch
from
2e2938c to
9259e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor to enable passing scope IDs to various methods, in service of #23167.