[ty] Fix Step 5 overload ambiguity for multi-argument calls#23576
Open
charliermarsh wants to merge 2 commits intomainfrom
Open
[ty] Fix Step 5 overload ambiguity for multi-argument calls#23576charliermarsh wants to merge 2 commits intomainfrom
charliermarsh wants to merge 2 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownsphinx
prefect
flake8
trio
|
|
charliermarsh
force-pushed
the
charlie/multi
branch
from
e46cb73 to
d0df10a
Compare
Member
Author
|
(Going to revert back to |
charliermarsh
force-pushed
the
charlie/multi
branch
2 times, most recently
from
509843f to
47e8714
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
type-assertion-failure |
27 | 0 | 3 |
| Total | 27 | 0 | 3 |
Raw diff (30 changes)
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/frame/test_frame.py:2849:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/frame/test_frame.py:2850:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/frame/test_frame.py:2851:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/indexes/test_mul.py:96:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Index[Any]`
+ tests/indexes/test_mul.py:102:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Index[Any]`
+ tests/indexes/test_sub.py:91:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Index[Any]`
+ tests/indexes/test_sub.py:97:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Index[Any]`
+ tests/series/test_add.py:162:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_add.py:168:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_add.py:174:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_add.py:180:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:126:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:138:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:144:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:159:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:165:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:171:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_mul.py:177:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:129:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:141:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:147:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:162:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:168:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:174:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
+ tests/series/test_sub.py:180:11 error[type-assertion-failure] Type `Unknown` does not match asserted type `Series[Any]`
scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/linalg/test__procrustes.pyi:25:1 error[type-assertion-failure] Type `Unknown` does not match asserted type `tuple[Unknown, float64]`
+ tests/linalg/test__procrustes.pyi:26:1 error[type-assertion-failure] Type `Unknown` does not match asserted type `tuple[Unknown, float64]`
- tests/linalg/test__procrustes.pyi:21:1 error[type-assertion-failure] Type `tuple[Unknown, float64]` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
+ tests/linalg/test__procrustes.pyi:21:1 error[type-assertion-failure] Type `Unknown` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
- tests/linalg/test__procrustes.pyi:24:1 error[type-assertion-failure] Type `tuple[Unknown, float64]` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
+ tests/linalg/test__procrustes.pyi:24:1 error[type-assertion-failure] Type `Unknown` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
- tests/linalg/test__procrustes.pyi:27:1 error[type-assertion-failure] Type `tuple[Unknown, float64]` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
+ tests/linalg/test__procrustes.pyi:27:1 error[type-assertion-failure] Type `Unknown` does not match asserted type `tuple[Unknown, floating[_32Bit] | float64]`
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
charliermarsh
force-pushed
the
charlie/multi
branch
from
47e8714 to
987748b
Compare
Member
|
Considering the test case added in this PR, it seems that the PR is converting the assignability check between the top materialization of the argument types which is # arg types: (A[Any], A[Any])
tuple[A[object], A[object]]and, the tuple of union of parameter types upto the specific overload: # This is at overload index 2 (which is the third overload)
# Tuple of union of parameters at same position
tuple[A[None] | A[Any], A[None] | A[Any]]To now checking assignment between the same top materialization of argument types, but doing a union of tuple of parameter types: # This is at overload index 2 (which is the third overload)
tuple[A[None], A[None]] | tuple[A[None], A[Any]] | tuple[A[Any], A[None]]which is how the step 5 is unable to filter out any overloads making the match ambiguous. I'd need to think through whether this approach is correct but for context, here's the discussion on the original approach: https://discord.com/channels/1039017663004942429/1380022837947138098/1380368239095316480 Need to hop into a 1:1, but want to look at a couple of ecosystem diagnostics that have been added. |
Member
|
This seems like a regression?
But, on considering |
Member
Oh, this seems probably like a separate issue. This is the minimal code: import pandas as pd
def _():
p = pd.Period("2012-1-1", freq="D")
as_period_index = pd.period_range("2012-1-1", periods=10, freq="D")
as_period_series = pd.Series(as_period_index)
offset_series = as_period_series - as_period_series
reveal_type(offset_series)
reveal_type(p + offset_series)Here, the inferred type of def _(s: pd.Series[Any]):
# This is `Unknown` in this PR but `Series[Any]` on `main`
reveal_type(s - s) |
charliermarsh
force-pushed
the
charlie/multi
branch
from
987748b to
e726461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now preserve cross-argument correlation by evaluating a union of per-overload parameter tuples, instead of collapsing parameters independently.
See: astral-sh/ty#2906.