[ty] Fix type[T] inference for TypedDict protocol bounds#24423
Open
charliermarsh wants to merge 1 commit intomainfrom
Open
[ty] Fix type[T] inference for TypedDict protocol bounds#24423charliermarsh wants to merge 1 commit intomainfrom
charliermarsh wants to merge 1 commit intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
Memory usage reportMemory usage unchanged ✅ |
|
576287b to
1c2877a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My understanding after reasoning through this for a while (with limited prior experience around this part of the codebase): typically, when solving for
type[T], given a class, we convert to the instance of that class, then inferTfrom that instance type.This fails specifically for cases like:
Because
__required_keys__exists on theTypedDictclass, but not on instances, apparently:This PR adds a special case to the specialization code for
TypedDictsuch that if the instance doesn't satisfy the bound, but the class object does, we allow it to satisfytype[T].This does not change protocol matching for instances, because if we did make the same change there, we'd be misrepresenting whether
__required_keys__is available onTypedDictinstances.Closes #24423.