[ty] Implement workspace/didChangeConfiguration#24712
Open
pierrem964 wants to merge 10 commits intoastral-sh:mainfrom
Open
[ty] Implement workspace/didChangeConfiguration#24712pierrem964 wants to merge 10 commits intoastral-sh:mainfrom
workspace/didChangeConfiguration#24712pierrem964 wants to merge 10 commits intoastral-sh:mainfrom
Conversation
pierrem964
requested review from
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
reviewed
Apr 20, 2026
MichaReiser
reviewed
Apr 24, 2026
| }, | ||
| ); | ||
|
|
||
| Ok(()) |
Member
There was a problem hiding this comment.
We should call publish_diagnostics_if_needed here for clients using the push diagnostics model.
Author
There was a problem hiding this comment.
Do we need to updates tests to cover this?
| fn run( | ||
| session: &mut Session, | ||
| client: &Client, | ||
| _params: types::DidChangeConfigurationParams, |
Member
There was a problem hiding this comment.
The params do contain the changed setting. Do you know if it includes all settings or do clients indeed only send the changed settings?
pierrem964
force-pushed
the
pgm/workspace-did-change-configuration
branch
from
0d5366f to
7ed12ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements astral-sh/ty#953
Adds a notification handler for
workspace/didConfigurationChange. Re initializesworkspaceswhen this is received with the newly pulled settings.Workspaces are just reinitialized with a new settings passed from the client.
Copied code from #20545, so credit to @Guillaume-Fgt for that.
Test Plan
I've added a unit test in configuration making sure this runs successfully. I am unsure if this is sufficient so please let me know how I can improve the testing implemented in this PR.