docs: fix PLR0124 description to not claim self-comparison always returns the same value#24749
Open
avasis-ai wants to merge 1 commit intoastral-sh:mainfrom
Open
docs: fix PLR0124 description to not claim self-comparison always returns the same value#24749avasis-ai wants to merge 1 commit intoastral-sh:mainfrom
avasis-ai wants to merge 1 commit intoastral-sh:mainfrom
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| B909 | 2 | 2 | 0 | 0 | 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22160
Summary
PLR0124 documentation previously stated that comparing a name to itself "always results in the same value". This is incorrect because
__eq__can be overridden (e.g.,float('nan') == float('nan')returnsFalse).Updated to match the suggestion in the issue:
Comparing a name to itself typically results in a truthy value, and is likely a mistake.