Filter overloads based on return type for ParamSpec mapping#24769
Draft
dhruvmanila wants to merge 1 commit intomainfrom
Draft
Filter overloads based on return type for ParamSpec mapping#24769dhruvmanila wants to merge 1 commit intomainfrom
dhruvmanila wants to merge 1 commit intomainfrom
Conversation
dhruvmanila
force-pushed
the
dhruv/filter-overloads-based-on-return-type
branch
from
dfed2c5 to
23f606f
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportMemory usage unchanged ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This seems like a quickfix but ideally the constraint solver should just step in and remove the unmatched overloads from the
ParamSpecspecialization.Test Plan