[ty] Fix notifications about watched changes for entities outside any workspace#24775
Open
[ty] Fix notifications about watched changes for entities outside any workspace#24775
Conversation
EliteTK
requested review from
BurntSushi,
Gankra,
MichaReiser,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
EliteTK
changed the title
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportMemory usage unchanged ✅ |
|
EliteTK
force-pushed
the
tk/watching-nonlocal-environments
branch
2 times, most recently
from
9c68be9 to
4f81e82
Compare
This is to avoid needing to clone a vec a million times but I almost regret doing this :S
EliteTK
force-pushed
the
tk/watching-nonlocal-environments
branch
from
4f81e82 to
41d0607
Compare
MichaReiser
approved these changes
Apr 21, 2026
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Thank you!
This makes sense to me. I suspect that we now end up invalidating multiple dbs when any pyproject.toml changed but I don't think this is worth special casing (at least now).
AlexWaygood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Distribute watched file change events generated by the LSP client to all dbs.
This simplifies the filtering logic to be handled by each db, and also fixes venvs which are outside the workspace (which can happen for symlinked environments).
Test Plan
Neovim, and a custom test harness (let me know if there is a way to test this in ty itself, Micha made it sound like it wasn't so easy.