You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NewType is nominal for static typing, but its constructor returns the input object unchanged at runtime. Prior to this change, we used ordinary type disjointness to evaluate and narrow is comparisons, so two distinct NewTypes with the same concrete base could be treated as unable to share an object and valid branches narrowed to Never:
fromtypingimportNewTypeclassFoo: ...
FooNewType1=NewType("FooNewType1", Foo)
FooNewType2=NewType("FooNewType2", Foo)
foo=Foo()
foo1=FooNewType1(foo)
foo2=FooNewType2(foo)
reveal_type(foo1isfoo2) # main: Literal[False]; this PR: booliffoo1isfoo2: # True at runtimereveal_type(foo1) # main: Never; this PR: FooNewType1reveal_type(foo2) # main: Never; this PR: FooNewType2
This PR projects NewTypes to their runtime representations before evaluating identity.
Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingtyMulti-file analysis & type inference
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewTypeis nominal for static typing, but its constructor returns the input object unchanged at runtime. Prior to this change, we used ordinary type disjointness to evaluate and narrowiscomparisons, so two distinct NewTypes with the same concrete base could be treated as unable to share an object and valid branches narrowed toNever:This PR projects NewTypes to their runtime representations before evaluating identity.
Closes astral-sh/ty#3552.