[ty] Disambiguate identical base names in inherited method conflicts#26458
Draft
charliermarsh wants to merge 1 commit into
Draft
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
Memory usage reportMemory usage unchanged ✅ |
3a575a3 to
4fe89d1
Compare
d1d784a to
1a27144
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-method-override |
0 | 0 | 48 |
| Total | 0 | 0 | 48 |
Raw diff (48 changes)
mypy (https://github.com/python/mypy)
- mypy/typeshed/stdlib/encodings/ascii.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/ascii.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.ascii.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/ascii.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/ascii.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.ascii.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/ascii.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/ascii.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.ascii.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/ascii.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/ascii.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.ascii.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/base64_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/base64_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.base64_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/base64_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/base64_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.base64_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/base64_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/base64_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.base64_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/base64_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/base64_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.base64_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/bz2_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/bz2_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.bz2_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/bz2_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/bz2_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.bz2_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/bz2_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/bz2_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.bz2_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/bz2_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/bz2_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.bz2_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/charmap.pyi:23:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/charmap.pyi:23:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.charmap.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/charmap.pyi:28:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/charmap.pyi:28:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.charmap.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/hex_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/hex_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.hex_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/hex_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/hex_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.hex_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/hex_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/hex_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.hex_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/hex_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/hex_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.hex_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/latin_1.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/latin_1.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.latin_1.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/latin_1.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/latin_1.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.latin_1.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/latin_1.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/latin_1.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.latin_1.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/latin_1.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/latin_1.pyi:19:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.latin_1.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/quopri_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/quopri_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.quopri_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/quopri_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/quopri_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.quopri_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/quopri_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/quopri_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.quopri_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/quopri_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/quopri_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.quopri_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.raw_unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.raw_unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:20:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/raw_unicode_escape.pyi:20:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.raw_unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/rot_13.pyi:16:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/rot_13.pyi:16:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.rot_13.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/rot_13.pyi:16:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/rot_13.pyi:16:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.rot_13.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/rot_13.pyi:17:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/rot_13.pyi:17:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.rot_13.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/rot_13.pyi:17:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/rot_13.pyi:17:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.rot_13.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/unicode_escape.pyi:18:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/unicode_escape.pyi:20:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/unicode_escape.pyi:20:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.unicode_escape.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/uu_codec.pyi:22:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/uu_codec.pyi:22:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.uu_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/uu_codec.pyi:22:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/uu_codec.pyi:22:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.uu_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/uu_codec.pyi:25:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/uu_codec.pyi:25:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.uu_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/uu_codec.pyi:25:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/uu_codec.pyi:25:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.uu_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/zlib_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/zlib_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.zlib_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/zlib_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/zlib_codec.pyi:20:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.zlib_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/zlib_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ mypy/typeshed/stdlib/encodings/zlib_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `mypy.typeshed.stdlib.encodings.zlib_codec.Codec` is incompatible with method from `codecs.Codec`
- mypy/typeshed/stdlib/encodings/zlib_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ mypy/typeshed/stdlib/encodings/zlib_codec.pyi:23:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `mypy.typeshed.stdlib.encodings.zlib_codec.Codec` is incompatible with method from `codecs.Codec`
pip (https://github.com/pypa/pip)
- src/pip/_vendor/idna/codec.py:127:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ src/pip/_vendor/idna/codec.py:127:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `decode` incompatibly: method from `pip._vendor.idna.codec.Codec` is incompatible with method from `codecs.Codec`
- src/pip/_vendor/idna/codec.py:127:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ src/pip/_vendor/idna/codec.py:127:7 error[invalid-method-override] Base classes for class `StreamWriter` define method `encode` incompatibly: method from `pip._vendor.idna.codec.Codec` is incompatible with method from `codecs.Codec`
- src/pip/_vendor/idna/codec.py:131:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: `Codec.decode` is incompatible with `Codec.decode`
+ src/pip/_vendor/idna/codec.py:131:7 error[invalid-method-override] Base classes for class `StreamReader` define method `decode` incompatibly: method from `pip._vendor.idna.codec.Codec` is incompatible with method from `codecs.Codec`
- src/pip/_vendor/idna/codec.py:131:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: `Codec.encode` is incompatible with `Codec.encode`
+ src/pip/_vendor/idna/codec.py:131:7 error[invalid-method-override] Base classes for class `StreamReader` define method `encode` incompatibly: method from `pip._vendor.idna.codec.Codec` is incompatible with method from `codecs.Codec`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on #26430, which adds diagnostics for incompatible methods inherited from multiple bases.
When two conflicting owners share a class name, the parent PR currently renders both methods identically:
This PR uses ty's existing ambiguous-name display settings for those owner names. Classes from different modules are qualified as
left.Baseandright.Base; if a module-level name is rebound and the qualified names still collide, the diagnostic also includes each class's source location.