exclude pragma from line length calculation - #27313
Open
ericbuehl wants to merge 3 commits into
Open
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| I001 | 57 | 57 | 0 | 0 | 0 |
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+58 -1 violations, +0 -0 fixes in 4 projects; 53 projects unchanged)
python/typeshed (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W
+ stubs/pika/pika/adapters/twisted_connection.pyi:4:1: unsorted-imports [*] Import block is un-sorted or un-formatted
python-poetry/poetry (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --no-fix --output-format concise --preview
+ src/poetry/console/commands/export.py:1:1: unsorted-imports [*] Import block is un-sorted or un-formatted
reflex-dev/reflex (+3 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --no-fix --output-format concise --preview
+ packages/reflex-hosting-cli/src/reflex_cli/v2/cli.py:554:17: unsorted-imports [*] Import block is un-sorted or un-formatted + packages/reflex-hosting-cli/src/reflex_cli/v2/secrets.py:161:17: unsorted-imports [*] Import block is un-sorted or un-formatted + tests/units/test_model.py:1:1: unsorted-imports [*] Import block is un-sorted or un-formatted
home-assistant/core (+53 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --no-fix --output-format concise --preview
+ homeassistant/components/backup/__init__.py:102:9: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/cloud/google_config.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/config/automation.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/config/script.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/demo/alarm_control_panel.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/device_automation/__init__.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/energy/sensor.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted - homeassistant/components/esphome/manager.py:130:92: noqa-comments [*] `noqa` comment used instead of `ruff: ignore` + homeassistant/components/esphome/manager.py:130:92: unused-noqa [*] Unused `noqa` directive (unused: `I001`) + homeassistant/components/ffmpeg_noise/binary_sensor.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/geo_location/__init__.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/google_assistant/helpers.py:659:13: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/homeassistant_hardware/util.py:318:5: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/homekit_controller/config_flow.py:358:9: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/http/view.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/intent/timers.py:461:13: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/number/__init__.py:3:1: unsorted-imports [*] Import block is un-sorted or un-formatted + homeassistant/components/recorder/auto_repairs/schema.py:248:9: unsorted-imports [*] Import block is un-sorted or un-formatted ... 37 additional changes omitted for rule unsorted-imports ... 36 additional changes omitted for project
Changes by rule (3 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| unsorted-imports | 57 | 57 | 0 | 0 | 0 |
| unused-noqa | 1 | 1 | 0 | 0 | 0 |
| noqa-comments | 1 | 0 | 1 | 0 | 0 |
Contributor
|
the all-or-nothing is_pragma_comment check misses mixed comments — something like |
Sanjays2402
reviewed
Jul 31, 2026
| /// ) | ||
| /// ``` | ||
| fn add_comment_width(line_width: LineWidthBuilder, comment: &str) -> LineWidthBuilder { | ||
| if is_pragma_comment(comment) { |
Contributor
There was a problem hiding this comment.
the width you skip here can come back as an E501: overlong.rs only strips a pragma when the line has exactly one comment (let [comment_range] = comment_ranges.comments_in_range(...)), but format_single_line concatenates every atop/inline/trailing comment onto the one line. so from m import x # explain # noqa: TID251 now stays unwrapped at, say, 95 chars and then line-too-long flags it because two comments in the range means no stripping at all.
Author
There was a problem hiding this comment.
I added a test case which I think should demonstrate your concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiple issues arise of line length limits conflicting with per-line suppressions. it was proposed that pragmas should not be included in line length calculation. this is an attempt at that
#12901
#12179
#20042
#27059
Test Plan