Handle a symlink edge case - #88
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
marked this pull request as ready for review
June 24, 2026 22:21
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We defer symlink creation always.
On case-insensitive filesystems (APFS...) that means that we treat
Fooandfooas distinct when doing our initial conflict check. Then, when we actually finalize the symlink graph,fooconflicts withFoowhen materialized on the filesystem.We now handle that correctly: when overwrites are allowed we allow the second symlink to clobber the first (effectively a no-op). When overwrites are disabled we fail with our original
PathCollisionerror.