Tweak Builder APIs - #93
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Now that FilePayload is constructable through public APIs, we need to make sure a user doesn't create one, call `next_chunk`, and then pass it to us in a partial state. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
marked this pull request as ready for review
June 25, 2026 17:11
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks our Builder APIs (on top of
ArchiveBuilder) in two ways that make downstream use in uv possible:add_entryis nowadd_file, and it takes anEntryPayloadinstead of a pre-allocated byte slice.EntryPayloadin turn can be constructed from a slice, from an async reader, etc.add_directoryis renamed toadd_directory_alladd_directoryonly adds a directory entry without any actual recursion/filesystem access whatsoever.