Validate asm qualifiers in the owned parser - #541
Open
charliermarsh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre-parser scan treated every
asmidentifier as assembly, so valid C11 such astypedef int asm; asm const value = 1;failed before parsing. We validate qualifiers when parsing an actual asm statement and remove the separate source scanner.The regression now passes for both C11 compiler profiles and remains rejected where GNU mode reserves the keyword. Parser, semantic, retained-asm, and native GCC/Clang checks pass, including invalid qualifier diagnostics at their source offsets.