Add attestations for release artifacts and Docker images#2827
Add attestations for release artifacts and Docker images#2827woodruffw merged 3 commits intoastral-sh:mainfrom
Conversation
|
cc @woodruffw per astral-sh/ruff#23111 (comment) :^) |
|
Thanks @shaanmajid, assigning myself! I should be able to review this tomorrow. |
2952c81 to
600839a
Compare
|
Rebased onto latest main to resolve a merge conflict. No rush, but ready for review whenever you get a chance! |
|
friendly ping @woodruffw |
| "actions/upload-artifact" = "b7c566a772e6b6bfb58ed0dc250532a479d7789f" # v6.0.0 | ||
| "actions/download-artifact" = "37930b1c2abaa49bbe596cd826c3c89aef350131" # v7.0.0 | ||
| "actions/attest-build-provenance" = "c074443f1aee8d4aeeae555aebba3282517141b2" #v2.2.3 | ||
| "actions/attest-build-provenance" = "00014ed6ed5efc5b1ab7f7f34a39eb55d41aa4f8" # v3.1.0 |
There was a problem hiding this comment.
Doesn't need to be done with this PR, but I believe there's a v4 series of attest-build-provenance (which in turn just makes it a wrapper around actions/attest). So maybe a good follow-up would be bumping to that or replacing with actions/attest entirely.
There was a problem hiding this comment.
Happy to bump to v4 either in this PR or later (although will note that at the time of writing, it's less than a week old). Would love to switch to just actions/attest, but I believe that would need upstream support from cargo-dist. Will leave an issue there.
There was a problem hiding this comment.
I'm good with waiting on the bump!
|
@woodruffw can we merge this or are we waiting for another change? |
|
Nope, it's good to go (modulo the conflict). |
600839a to
7dacf49
Compare
|
Rebased and solved the |
Summary
Adds GitHub artifact attestations (SLSA provenance) for release artifacts and Docker images.
Users will be able to verify artifacts with:
Test Plan
Tested end-to-end release and attestation verification on my fork.
Verify release artifacts:
gh release download 0.0.17 --repo shaanmajid/ty --pattern "ty-x86_64-unknown-linux-gnu.tar.gz" --dir /tmp gh attestation verify /tmp/ty-x86_64-unknown-linux-gnu.tar.gz --repo shaanmajid/tyVerify Docker images:
Notes
actions/attest-build-provenancewas preexisting indist-workspace.tomlbut unused, so the upgrade across major versions is safe.