Skip to content

Fix renovate actions/*-artifact updates#2956

Merged
AlexWaygood merged 1 commit intomainfrom
alex/renovate
Mar 4, 2026
Merged

Fix renovate actions/*-artifact updates#2956
AlexWaygood merged 1 commit intomainfrom
alex/renovate

Conversation

@AlexWaygood
Copy link
Member

The same as astral-sh/ruff#23675:

The intention here is that this should be a regex match. But that evidently is not working (astral-sh/ruff#23656 and astral-sh/ruff#23655 were filed as separate PRs rather than one combined PR). Looking at the renovate docs, it's possible that we need to surround the string with / in order for it to be considered a regular expression -- i.e., /actions/.*-artifact/ rather than actions/.*-artifact. But a regex here also just feels like it's overcomplicating things anyway -- the only ones we aare about are upload-artifact and download-artifact!

The same problem evidently exists on this repo too: see #2933 and #2934

The same as astral-sh/ruff#23675:

> The intention here is that this should be a regex match. But that evidently is not working (astral-sh/ruff#23656 and astral-sh/ruff#23655 were filed as separate PRs rather than one combined PR). Looking at the renovate docs, it's possible that we need to surround the string with `/` in order for it to be considered a regular expression -- i.e., `/actions/.*-artifact/` rather than `actions/.*-artifact`. But a regex here also just feels like it's overcomplicating things anyway -- the only ones we aare about are `upload-artifact` and `download-artifact`!

The same problem evidently exists on this repo too: see #2933 and #2934
@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Mar 4, 2026
@AlexWaygood AlexWaygood enabled auto-merge (squash) March 4, 2026 11:10
@AlexWaygood AlexWaygood merged commit fba59f6 into main Mar 4, 2026
13 checks passed
@AlexWaygood AlexWaygood deleted the alex/renovate branch March 4, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant