Add typeshed diff link to changelog during release#2957
Merged
AlexWaygood merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
Before updating the ruff submodule, save the current typeshed source commit from `ruff/crates/ty_vendored/vendor/typeshed/source_commit.txt`. After rooster generates the changelog, if the typeshed commit changed, automatically append a `[Typeshed diff](...)` link to any "Sync vendored typeshed stubs" changelog entries. This removes the need for manual PR suggestions to add the link on every release. https://claude.ai/code/session_014HpqW7xbo81UrgXcFWrR7f
`sed -i` requires a backup extension argument on macOS (BSD sed) but not on Linux (GNU sed). Using a temp file + mv avoids this entirely. https://claude.ai/code/session_014HpqW7xbo81UrgXcFWrR7f
carljm
approved these changes
Mar 4, 2026
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Thank you! Looks reasonable, guess we'll see if it works :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically generate and append a typeshed diff link to the changelog when the vendored typeshed source commit changes during a release.
The script now:
Test Plan
No idea. I tried mucking around locally to fool the release script and/or rooster into thinking that we were doing a release that updated typeshed, but to no avail. I guess we just have to wait until we cut a release that includes a typeshed sync to see if this actually worked or not?