Always reinstall local source trees passed to uv pip install
#12176
+471
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/explicit
branch
from
07ad594 to
2e977a2
Compare
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/explicit
branch
6 times, most recently
from
c8935ae to
db7d652
Compare
konstin
approved these changes
Mar 17, 2025
zanieb
reviewed
Mar 17, 2025
crates/uv-cache/src/lib.rs
Outdated
| || path.is_some_and(|path| { | ||
| paths | ||
| .iter() | ||
| .any(|target| same_file::is_same_file(path, target).unwrap_or(true)) |
There was a problem hiding this comment.
On failure we assume true and always invalidate? That seems surprising.
There was a problem hiding this comment.
(I don't feel strongly, but am curious for your thinking here)
There was a problem hiding this comment.
Removed it. I didn't realize it errors when one file doesn't exist; I just didn't think about it deeply, thanks!
zanieb
reviewed
Mar 17, 2025
| Self::Packages(packages) => packages.contains(package_name), | ||
| Self::Packages(.., paths) => paths | ||
| .iter() | ||
| .any(|target| same_file::is_same_file(path, target).unwrap_or(true)), |
charliermarsh
force-pushed
the
charlie/explicit
branch
from
db7d652 to
dc2002f
Compare
zanieb
approved these changes
Mar 17, 2025
|
Yeah, just local source trees. |
zanieb
changed the title
uv pip installuv pip install
charliermarsh
force-pushed
the
charlie/explicit
branch
from
dc2002f to
c001216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ended up being more involved than expected. The gist is that we setup all the packages we want to reinstall upfront (they're passed in on the command-line); but at that point, we don't have names for all the packages that the user has specified. (Consider, e.g.,
uv pip install .-- we don't have a name for., so we can't add it to the list ofReinstallpackages.)Now,
Reinstallalso accepts paths, so we can augmentReinstallbased on the user-provided paths.Closes #12038.