Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reinstall source trees passed to uv pip install #12176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 14, 2025

Summary

This ended up being more involved than expected. The gist is that we setup all the packages we want to reinstall upfront (they're passed in on the command-line); but at that point, we don't have names for all the packages that the user has specified. (Consider, e.g., uv pip install . -- we don't have a name for ., so we can't add it to the list of Reinstall packages.)

Now, Reinstall also accepts paths, so we can augment Reinstall based on the user-provided paths.

Closes #12038.

@charliermarsh charliermarsh added the no-build Disable building binaries in CI label Mar 14, 2025
@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality cache Caching of packages and metadata labels Mar 14, 2025
@charliermarsh charliermarsh requested review from zanieb and konstin March 14, 2025 20:16
@charliermarsh charliermarsh force-pushed the charlie/explicit branch 5 times, most recently from f66b3e9 to c8935ae Compare March 15, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache Caching of packages and metadata enhancement New feature or improvement to existing functionality no-build Disable building binaries in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running uv pip install . should systematically reinstall the package
1 participant