Replace change detection GitHub Action #12188
Merged
+55
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/change
branch
3 times, most recently
from
db0fc27 to
dd7e0b0
Compare
charliermarsh
had a problem deploying
to
uv-test-publish
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/change
branch
from
dd7e0b0 to
1d92054
Compare
charliermarsh
added
testing
charliermarsh
changed the title
charliermarsh
had a problem deploying
to
uv-test-publish
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/change
branch
from
1d92054 to
9f9acdf
Compare
charliermarsh
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
reviewed
Mar 15, 2025
.github/workflows/ci.yml
Outdated
| while IFS= read -r file; do | ||
| # Skip if file matches exclusion patterns. | ||
| if [[ "$file" =~ ^docs/ && ! "$file" =~ ^docs/reference/(cli|settings).md && ! "$file" =~ ^docs/configuration/environment.md ]]; then | ||
| echo "Skipping $file (matches `docs/` pattern)" |
There was a problem hiding this comment.
These backticks are going to evaluate
❯ echo "foo `bar`"
zsh: command not found: bar
foo
9f9acdf to
2dfd32a
Compare
charliermarsh
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
approved these changes
Mar 15, 2025
.github/workflows/ci.yml
Outdated
|
|
||
| while IFS= read -r file; do | ||
| # Skip if file matches exclusion patterns. | ||
| if [[ "$file" =~ ^docs/ && ! "$file" =~ ^docs/reference/(cli|settings).md && ! "$file" =~ ^docs/configuration/environment.md ]]; then |
There was a problem hiding this comment.
I'd use "${file}" throughout — I don't think there's an attack vector here because of the way you're iterating but it's safer.
.github/workflows/ci.yml
Outdated
| CODE_CHANGED=true | ||
| break | ||
|
|
||
| done <<< "$CHANGED_FILES" |
There was a problem hiding this comment.
Suggested change
| done <<< "$CHANGED_FILES" | |
| done <<< "${CHANGED_FILES}" |
.github/workflows/ci.yml
Outdated
| break | ||
|
|
||
| done <<< "$CHANGED_FILES" | ||
| echo "code_any_changed=$CODE_CHANGED" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Suggested change
| echo "code_any_changed=$CODE_CHANGED" >> "$GITHUB_OUTPUT" | |
| echo "code_any_changed=${CODE_CHANGED}" >> "$GITHUB_OUTPUT" |
| - "!**/*.md" | ||
| - "!bin/**" | ||
| - "!assets/**" | ||
| # Generated markdown and JSON files are checked during test runs |
There was a problem hiding this comment.
It might be worth retaining the comment on why we run tests on these files
charliermarsh
force-pushed
the
charlie/change
branch
from
2dfd32a to
d057844
Compare
charliermarsh
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tj-actions/changed-filesno longer exists due to a malicious commit. This PR replaces it with a minimal shell script to get us unblocked.