Validate URL wheel tags against Requires-Python and required environments
#16824
Conversation
charliermarsh
force-pushed
the
charlie/req
branch
from
1fce755 to
3542bfb
Compare
| ----- stderr ----- | ||
| × No solution found when resolving dependencies: | ||
| ╰─▶ Because only numpy==2.3.5 is available and numpy==2.3.5 has no wheels with a matching Python version tag (e.g., `cp312`), we can conclude that all versions of numpy cannot be used. | ||
| And because your project depends on numpy, we can conclude that your project's requirements are unsatisfiable. |
There was a problem hiding this comment.
Today, this resolution passes and the wheel is just omitted from the lockfile.
| ----- stderr ----- | ||
| × No solution found when resolving dependencies: | ||
| ╰─▶ Because only numpy==2.3.5 is available and numpy==2.3.5 has no Windows-compatible wheels, we can conclude that all versions of numpy cannot be used. | ||
| And because your project depends on numpy, we can conclude that your project's requirements are unsatisfiable. |
There was a problem hiding this comment.
Same here -- this passes too.
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
left a comment
konstin
left a comment
There was a problem hiding this comment.
One question about the resolver order, otherwise looks good.
| for environment_marker in self.options.required_environments.iter().copied() { | ||
| // If the platform is part of the current environment... | ||
| if env.included_by_marker(environment_marker) | ||
| && !find_environments(id, pubgrub).is_disjoint(environment_marker) |
There was a problem hiding this comment.
Here, we compute through which marker paths the package is currently reachable. Doesn't that mean we can miss an incompatible package if the dependency with a wider marker only appears later?
There was a problem hiding this comment.
Hmm, maybe? But I think this is the same strategy as in the choose_version_registry path`.
There was a problem hiding this comment.
It looks like we're getting saved by pseudo-packages having their version selection, with this PR this fails as it should:
[project]
name = "test-toml"
version = "0.1.0"
requires-python = ">=3.14"
dependencies = [
'numpy; sys_platform == "win32"',
'pandas',
]
[tool.uv]
required-environments = ['sys_platform == "linux"', 'sys_platform == "win32"']
[tool.uv.sources]
numpy = { url = "https://files.pythonhosted.org/packages/a3/2e/235b4d96619931192c91660805e5e49242389742a7a82c27665021db690c/numpy-2.3.5-cp314-cp314-win_amd64.whl" }
Summary
Closes #16818.