Merged
Conversation
| - plan | ||
| if: ${{ needs.plan.outputs.publishing == 'true' || fromJson(needs.plan.outputs.val).ci.github.pr_run_mode == 'upload' || inputs.tag == 'dry-run' }} | ||
| uses: ./.github/workflows/build-binaries.yml | ||
| uses: ./.github/workflows/build-release-binaries.yml |
Check warning
Code scanning / zizmor
secrets unconditionally inherited by called workflow Warning
1c0f41d to
ae5d548
Compare
3000ef1 to
46f86a0
Compare
0956e6f to
64d14fd
Compare
64d14fd to
b7e73f8
Compare
b7e73f8 to
6ed30f8
Compare
8dbf302 to
a0d7362
Compare
a0d7362 to
fdecf0f
Compare
Break apart the monolithic ci.yml into smaller, focused workflow files: - bench.yml, test.yml, test-integration.yml, test-system.yml, test-ecosystem.yml - check-fmt.yml, check-lint.yml, check-docs.yml, check-publish.yml, check-zizmor.yml - build-dev-binaries.yml, build-release-binaries.yml, test-windows-trampolines.yml, test-smoke.yml Use jq-based required-checks-passed job to verify all CI checks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fdecf0f to
bc43c76
Compare
| python-version: 3.12 | ||
|
|
||
| - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0 | ||
| - uses: Swatinem/rust-cache@779680da715d629ac1d338a641029a2f4372abb5 # v2.8.2 |
Member
There was a problem hiding this comment.
May want to decouple this?
Member
Author
There was a problem hiding this comment.
We were using inconsistent versions across the workflows. I'm not even sure why. I did have Claude audit that we weren't bumping to a version that we weren't using elsewhere in the file. I'll double check though.
Member
Author
There was a problem hiding this comment.
I confirmed we're using v2.8.2 in a bunch of places on main.
charliermarsh
approved these changes
Jan 12, 2026
zanieb
added a commit
that referenced
this pull request
Jan 12, 2026
We get a bunch of redundant skipped `Release / Build binary ...` jobs in CI otherwise, and I would rather the release workflow didn't have a pull request trigger at all. Follows #17388
zanieb
pushed a commit
that referenced
this pull request
Jan 22, 2026
`build-binaries.yml` was renamed to `build-release-binaries.yaml` in #17388.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is too big for an LLM context window and several contributors have complained about it being too scary to touch.
This also gets us collapsible sections in the UI.
I renamed some jobs for clarity in the meantime. And added a meta-job for required checks passing so we can avoid churn in our "Settings" when we change job names.
Note this was entirely refactored by Claude.