Conversation
| /// Allow upgrades for all packages in a dependency group, ignoring pinned versions in any | ||
| /// existing output file. | ||
| #[arg(long, help_heading = "Resolver options")] | ||
| pub upgrade_group: Vec<GroupName>, |
There was a problem hiding this comment.
Do we support package:group for workspace member group selection? We support that syntax elsewhere right?
There was a problem hiding this comment.
This is not supported in the project interface right now, deferring.
| Ok(()) | ||
| } | ||
|
|
||
| /// `--upgrade-group` is not supported in pip commands. |
There was a problem hiding this comment.
It probably make sense in some form, but deferring for now
| /// Returns `true` if no packages should be upgraded. | ||
| pub fn is_none(&self) -> bool { | ||
| matches!(self.strategy, UpgradeStrategy::None) | ||
| matches!(self.strategy, UpgradeStrategy::None) && self.groups.is_empty() |
There was a problem hiding this comment.
Shouldn't the set of groups somehow be on UpgradeStrategy? Similar to how we store the set of packages?
There was a problem hiding this comment.
E.g., it could be All, None, and Some, where Some includes groups and packages?
There was a problem hiding this comment.
Sure, that modeling seems a bit better, though I think it might be more disruptive. I'll look into it.
2 participants
Closes #13705
Note this only affects top-level group members, not transitive dependencies of them.