Don't silently ignore directories in source-include#18772
Open
Don't silently ignore directories in source-include#18772
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
commented
Mar 30, 2026
woodruffw
commented
Mar 30, 2026
konstin
reviewed
Mar 31, 2026
Signed-off-by: William Woodruff <william@astral.sh>
Member
Author
|
Okay, I simplified this a bit -- both (I've also added a test for that single-file include behavior, since I couldn't find a pre-existing one.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP.
This is a stab at fixing #16751. The basic observation here is that a user who tries to include something like
tests/almost certainly meanstests/**, so we use the same logic as insource_dist_matcherand append**.Closes #16751.
Test Plan
Added two new tests for this: one that ensures we transform
tests/correct and another that ensures we warn when the user passestests(i.e. without the trailing slash).