Open
Conversation
This updates adds missing range request bounds validation: astral-sh/async_http_range_reader#8 An open question is how we want to behave when the server has an incorrect range request implementation (while advertising range request support). In the current implementation, it warns with the index URL, so that the user is aware that the massive slowdown is caused by a server advertising broken features.
konstin
force-pushed
the
konsti/async_http_range_reader_0_11_0
branch
from
75e3ebf to
115fb00
Compare
| } else { | ||
| url | ||
| }; | ||
| warn_user_once!( |
Member
There was a problem hiding this comment.
I would be okay with this being a tracing warning, since it isn't necessarily something the user can proactively fix (if they don't control the server).
charliermarsh
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates async_http_range_reader to v0.11.0 to add the missing range request bounds validation: astral-sh/async_http_range_reader#8.
An open question is how we want to behave when the server has an incorrect range request implementation (while advertising range request support). In the current implementation, it warns with the index URL, so that the user is aware that the massive slowdown is caused by a server advertising broken features.
Also removes a dependency where the corresponding repo was deleted.
Fixes #18316