Stop stacking progress bars when a wheel download is retried#19111
Open
nooscraft wants to merge 1 commit intoastral-sh:mainfrom
Open
Stop stacking progress bars when a wheel download is retried#19111nooscraft wants to merge 1 commit intoastral-sh:mainfrom
nooscraft wants to merge 1 commit intoastral-sh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress bars for wheel downloads were started on every retry attempt, but only completed on success. When a transient network failure triggered the outer HTTP retry loop, failed attempts left the old bar behind, so retries could show stacked duplicate progress bars for the same package.
A new
DownloadProgressguard callson_download_completein itsDropimpl. Bothstream_wheelanddownload_wheelcreate the guard and let Drop clear the bar, so it is finalized whether the download succeeds or bails out via?. Covered by unit tests indistribution_database.rsthat check the start/drop pair and that a failure-failure-success retry sequence keeps start/complete counts balanced and paired by id.Closes #19110...