Skip to content

fix(trampoline): don't set PYTHONHOME for venv trampolines #19123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bojun-Vvibe wants to merge 2 commits into from
+12 −1
Closed

fix(trampoline): don't set PYTHONHOME for venv trampolines #19123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ec369d
fix(trampoline): don't set PYTHONHOME for venv trampolines
Apr 23, 2026
1000b9c
fix(trampoline): apply cargo fmt
BojunChai Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/uv-trampoline/src/bounce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,18 @@ fn make_child_cmdline() -> CString {
// whether `PYTHONHOME` was set by uv. This allows us to:
// - Override inherited `PYTHONHOME` from parent Python processes
// - Preserve user-defined `PYTHONHOME` values
if !is_virtualenv(python_exe.as_path()) {
//
Copy link
Copy Markdown
Contributor

@nooscraft nooscraft Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test-windows-trampolines / check on * CI jobs are failing. Per the workflow, these run cargo fmt --check and cargo clippy --all-features --target x86_64-pc-windows-msvc --tests -- -D warnings.

Please run:

cd crates/uv-trampoline
cargo fmt
cargo clippy --all-features --target x86_64-pc-windows-msvc --tests -- -D warnings

Then push the formatting fixes.

// We must check both `executable_name` (the trampoline itself,
// which may live inside a virtual environment's `Scripts`
// directory and target the base interpreter via the
// `python_path` resource) and `python_exe` (the resolved target
// interpreter). Otherwise, virtual environments built on top of
// managed interpreters would incorrectly receive `PYTHONHOME`
// pointing at the base installation, which then leaks into
// child processes and can shadow stdlib from a different Python
// (see https://github.com/astral-sh/uv/issues/19080).
if !is_virtualenv(executable_name.as_path()) && !is_virtualenv(python_exe.as_path())
{
let python_home = std::env::var(EnvVars::PYTHONHOME).ok();
let marker = std::env::var(EnvVars::UV_INTERNAL__PYTHONHOME).ok();

Expand Down
Loading