Remove build::build_with_hardlink test - #20005
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
added
internal
uv test inventory changesThis PR changes the tests when compared with the latest
|
zsol
approved these changes
Jun 26, 2026
konstin
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows #19991 -- we're now rejecting the main situation in which hardlinks appear in source distributions.
For context: this test was originally added in #11221 to backstop our behavior in astral-tokio-tar (which had accidentally regressed in terms of how hardlinks were extracted). But with #19979 our plan is to remove astral-tokio-tar entirely (eventually), so this test is effectively backstopping a behavior that we're intentionally removing (hardlinks are not well defined in sdist and are completely forbidden in wheels).
We might also want to remove
build_with_symlink, but it's more marginal since symlinks do appear in real-world sdists/source trees. #19979 isn't currently changing how we handle them.Test Plan
Intentionally deleting a backstop test 🙈