Remove member ID's#38
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
dynamic_expressions / eval
Details
| Benchmark suite | Current: 7921295 | Previous: e5e336f | Ratio |
|---|---|---|---|
evaluation/BuiltinF32/derivative |
16.260284 ms/iter (± 0.359851) |
16.877877 ms/iter (± 0.080186) |
0.96 |
evaluation/BuiltinF32/eval |
2.750314 ms/iter (± 0.122327) |
2.784826 ms/iter (± 0.063353) |
0.99 |
evaluation/BuiltinF64/derivative |
20.479642 ms/iter (± 0.111803) |
20.528925 ms/iter (± 0.059331) |
1.00 |
evaluation/BuiltinF64/eval |
3.281273 ms/iter (± 0.075238) |
3.29284 ms/iter (± 0.013548) |
1.00 |
evaluation/Float32/derivative |
11.331816 ms/iter (± 0.098749) |
11.283862 ms/iter (± 0.03718) |
1.00 |
evaluation/Float32/eval |
2.171671 ms/iter (± 0.028166) |
2.179077 ms/iter (± 0.014435) |
1.00 |
evaluation/Float64/derivative |
22.745593 ms/iter (± 0.366404) |
23.108435 ms/iter (± 0.08237) |
0.98 |
evaluation/Float64/eval |
4.373384 ms/iter (± 0.110637) |
4.417413 ms/iter (± 0.030165) |
0.99 |
utilities/Float32/clone |
8.34 us/iter (± 0.032) |
8.325 us/iter (± 0.019) |
1.00 |
utilities/Float32/combine_operators |
49.198 us/iter (± 0.197) |
49.471 us/iter (± 0.096) |
0.99 |
utilities/Float32/compress_constants |
6.184 us/iter (± 0.06) |
6.143 us/iter (± 0.059) |
1.01 |
utilities/Float32/count_depth_sizes/128 |
71.655 us/iter (± 1.995) |
71.368 us/iter (± 0.574) |
1.00 |
utilities/Float32/count_depth_sizes/20 |
4.096 us/iter (± 0.036) |
4.081 us/iter (± 0.016) |
1.00 |
utilities/Float32/count_depth_sizes/64 |
25.449 us/iter (± 0.841) |
25.121 us/iter (± 0.374) |
1.01 |
utilities/Float32/count_depth_sizes/8 |
1.66 us/iter (± 0.005) |
1.661 us/iter (± 0.006) |
1.00 |
utilities/Float32/counting |
4.006 us/iter (± 0.056) |
3.831 us/iter (± 0.033) |
1.05 |
utilities/Float32/simplify |
84.177 us/iter (± 0.232) |
86.055 us/iter (± 0.383) |
0.98 |
utilities/Float64/clone |
8.544 us/iter (± 0.015) |
8.57 us/iter (± 0.028) |
1.00 |
utilities/Float64/combine_operators |
48.917 us/iter (± 0.804) |
49.185 us/iter (± 0.439) |
0.99 |
utilities/Float64/compress_constants |
6.455 us/iter (± 0.151) |
6.009 us/iter (± 0.047) |
1.07 |
utilities/Float64/count_depth_sizes/128 |
71.874 us/iter (± 0.766) |
71.876 us/iter (± 0.542) |
1.00 |
utilities/Float64/count_depth_sizes/20 |
4.085 us/iter (± 0.014) |
4.087 us/iter (± 0.015) |
1.00 |
utilities/Float64/count_depth_sizes/64 |
25.271 us/iter (± 0.355) |
25.217 us/iter (± 0.275) |
1.00 |
utilities/Float64/count_depth_sizes/8 |
1.659 us/iter (± 0.007) |
1.695 us/iter (± 0.007) |
0.98 |
utilities/Float64/counting |
4.044 us/iter (± 0.024) |
3.817 us/iter (± 0.062) |
1.06 |
utilities/Float64/simplify |
87.071 us/iter (± 2.321) |
85.59 us/iter (± 0.329) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
symbolic_regression / optim
Details
| Benchmark suite | Current: 7921295 | Previous: e5e336f | Ratio |
|---|---|---|---|
search/equation_search |
1.547116599 s/iter (± 0.086911325) |
1.485828296 s/iter (± 0.062660438) |
1.04 |
utils/best_of_sample |
355 ns/iter (± 8) |
362 ns/iter (± 0) |
0.98 |
utils/check_constraints_x10 |
7.259 us/iter (± 0.01) |
6.66 us/iter (± 0.016) |
1.09 |
utils/compute_complexity_x10/u16 |
0 ns/iter (± 0) |
0 ns/iter (± 0) |
1 |
utils/insert_random_op_x10 |
3.551 us/iter (± 0.236) |
3.415 us/iter (± 0.137) |
1.04 |
utils/next_generation_x100 |
190.814 us/iter (± 2.312) |
194.099 us/iter (± 2.079) |
0.98 |
utils/optimize_constants_x10 |
14.661956 ms/iter (± 0.494798) |
14.642581 ms/iter (± 0.481097) |
1.00 |
utils/randomly_rotate_tree_x10 |
8.872 us/iter (± 0.045) |
8.966 us/iter (± 0.127) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were left over from the recorder functionality in SR.jl and aren't needed here.