Skip to content

Add option to raise errors or log only on DAG import failure #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pankajastro wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add option to raise errors or log only on DAG import failure #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions dagfactory/dagfactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ def load_yaml_dags(
if suffix is None:
suffix = [".yaml", ".yml"]
candidate_dag_files = []

errors = []
no_error_count = 0
if config_filepath:
factory = _DagFactory(config_filepath=config_filepath, defaults_config_path=defaults_config_path)
factory._generate_dags(globals_dict)
Expand All @@ -320,7 +321,15 @@ def load_yaml_dags(
try:
factory = _DagFactory(config_file_abs_path, defaults_config_dict=defaults_config_dict)
factory._generate_dags(globals_dict)
except Exception: # pylint: disable=broad-except
except Exception as e: # pylint: disable=broad-except
logging.exception("Failed to load dag from %s", config_file_path)
errors.append((config_file_path, e))
else:
logging.info("DAG loaded: %s", config_file_path)
no_error_count += 1

# TODO: Maybe enable based on config or env?
if errors:
heading = f"{len(errors)} DAGs failed, and an additional {no_error_count} were blocked from loading.\n"
msg = "\n".join(f"{i + 1}. {path}: {err}" for i, (path, err) in enumerate(errors))
raise Exception(f"{heading}{msg}")
Loading