Skip to content

Add pre-commit hooks adapted from astropy#245

Merged
astrofrog merged 2 commits into
astropy:mainfrom
lpsinger:pre-commit
Feb 25, 2026
Merged

Add pre-commit hooks adapted from astropy#245
astrofrog merged 2 commits into
astropy:mainfrom
lpsinger:pre-commit

Conversation

@lpsinger
Copy link
Copy Markdown
Contributor

@lpsinger lpsinger commented Feb 3, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.23%. Comparing base (1e55a9f) to head (b7af16c).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
astropy_healpix/__init__.py 0.00% 1 Missing ⚠️
astropy_healpix/bench.py 96.77% 1 Missing ⚠️
astropy_healpix/core.py 97.77% 1 Missing ⚠️
astropy_healpix/high_level.py 93.33% 1 Missing ⚠️
astropy_healpix/utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files           6        6           
  Lines         505      505           
=======================================
  Hits          486      486           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lpsinger lpsinger marked this pull request as draft February 3, 2025 22:36
@astrofrog
Copy link
Copy Markdown
Member

@lpsinger - I think it'd be good to get this in, would you have time to rebase? I think the easiest would be to remove the second commit and re-generate it after resolving the conflicts for the first commit.

@lpsinger lpsinger marked this pull request as ready for review February 25, 2026 17:19
@lpsinger lpsinger requested a review from astrofrog February 25, 2026 17:19
Copy link
Copy Markdown
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@astrofrog astrofrog merged commit 9eef902 into astropy:main Feb 25, 2026
11 of 12 checks passed
@lpsinger lpsinger deleted the pre-commit branch February 25, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants