HITRAN: Allow query of multiple molecules/isotopologues #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @keflavich! Thanks for submitting the PR.
|
|
Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. I noticed the following issues with this pull request:
Would it be possible to fix these? Thanks! If there are any issues with this message, please report them here. |
bsipocz
force-pushed
the
master
branch
2 times, most recently
from
ab0c591 to
712c326
Compare
bsipocz
requested changes
Dec 1, 2021
| @@ -152,6 +154,8 @@ def __init__(self, **kwargs): | |||
| super(HitranClass, self).__init__() | |||
|
|
|||
| def _args_to_payload(self, molecule_number=1, isotopologue_number=1, | |||
|
ping @keflavich |
|
I see the ping; I haven't had time to look. I want to see if I can get a student involved via this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation only allows single isotopologues and molecules, which makes search for transitions difficult if the carrier species is unknown.