Skip to content

Conversation

@snbianco
Copy link
Contributor

Some users have reported issues with queries to the PanSTARRS catalog due to inconsistencies in column metadata. We're in the midst of making updates to the service, and some columns are returning metadata that don't have certain keys we look for.

This PR updates the code that parses columns to be more robust to these inconsistencies. A column's name can come from column_name, or as a backup, name. If description doesn't exist, an empty string is used in its place. If either a column name or datatype can't be found, then the column is skipped. This won't impact what query methods return, but it will prevent a user from filtering on that particular column in queries.

@snbianco snbianco added the mast label Dec 22, 2025
@snbianco snbianco added the bug label Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.73%. Comparing base (ef48060) to head (8d9cf1a).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/collections.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
+ Coverage   71.72%   71.73%   +0.01%     
==========================================
  Files         235      235              
  Lines       20253    20258       +5     
==========================================
+ Hits        14527    14533       +6     
+ Misses       5726     5725       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco snbianco marked this pull request as ready for review December 22, 2025 19:52
@bsipocz bsipocz added this to the 0.4.12 milestone Dec 22, 2025
@snbianco snbianco requested a review from bsipocz December 22, 2025 20:01
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@bsipocz bsipocz merged commit bd28718 into astropy:main Dec 22, 2025
12 of 13 checks passed
@snbianco snbianco deleted the fix-ps1-catalog branch December 22, 2025 20:21
@snbianco snbianco restored the fix-ps1-catalog branch December 22, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants