Bugfix for handling PS1 catalog column metadata #3485
Merged
+14
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have reported issues with queries to the PanSTARRS catalog due to inconsistencies in column metadata. We're in the midst of making updates to the service, and some columns are returning metadata that don't have certain keys we look for.
This PR updates the code that parses columns to be more robust to these inconsistencies. A column's name can come from
column_name, or as a backup,name. Ifdescriptiondoesn't exist, an empty string is used in its place. If either a column name or datatype can't be found, then the column is skipped. This won't impact what query methods return, but it will prevent a user from filtering on that particular column in queries.