Allow opting in to limited API builds with EXTENSION_HELPERS_PY_LIMITED_API#110
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 57.45% 58.31% +0.85%
==========================================
Files 4 4
Lines 369 379 +10
==========================================
+ Hits 212 221 +9
- Misses 157 158 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cadair
left a comment
Cadair
left a comment
There was a problem hiding this comment.
Looks sensible from a phone review.
neutrinoceros
left a comment
neutrinoceros
left a comment
There was a problem hiding this comment.
post mortem, nit (feel free to ignore)
| if sys.version_info < (3, 11): | ||
| pytest.skip( | ||
| "This test requires setuptools>=65.4 which is only available for Python 3.11 and later" | ||
| ) |
There was a problem hiding this comment.
nit: could be a @pytest.mark.skipif
There was a problem hiding this comment.
Coming back to see I'm not sure this comment is correct actually; setuptools 80.9 appears to still support Python 3.9, so how would 65.4 require 3.11 ?
There was a problem hiding this comment.
Strange, when I tried running this on Python 3.10 older versions of setuptools would get installed.
3 participants
@neutrinoceros - just FYI, since you suggested this! :)
Also cc @lpsinger