Skip to content

Fixes for SAMP migration from astropy to pyvo#762

Merged
bsipocz merged 2 commits into
astropy:mainfrom
pllim:astropy-samp-fix
Jun 9, 2026
Merged

Fixes for SAMP migration from astropy to pyvo#762
bsipocz merged 2 commits into
astropy:mainfrom
pllim:astropy-samp-fix

Conversation

@pllim

@pllim pllim commented Jun 8, 2026

Copy link
Copy Markdown
Member

This is a follow-up of #729

Related issue: #761

pllim added 2 commits June 8, 2026 13:50
to not point to upstream deprecated command
@pllim pllim requested a review from bsipocz June 8, 2026 17:53
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.88%. Comparing base (69c3a1f) to head (cda1f62).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files          91       91           
  Lines       10312    10312           
=======================================
  Hits         8238     8238           
  Misses       2074     2074           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim

pllim commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

I will add a change log if you think we need it.

@astrofrog also suggested that pyvo removes the samp_hub CLI completely, so if you want to go with that instead, then this PR needs to be modified.

@astrofrog

Copy link
Copy Markdown
Member

Just to expand on my suggestion, we could move to a model where we no longer have a CLI command but set it up so that users can instead do e.g.:

python -m pyvo.samp.hub

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pllim. I'll see to the changelog before doing a release.

Comment thread setup.cfg
[options.entry_points]
console_scripts =
samp_hub = astropy.samp.hub_script:hub_script
samp_hub = pyvo.samp.hub_script:hub_script

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ of not noticing this in review.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens. No worries.

@bsipocz bsipocz added this to the v1.9.1 milestone Jun 9, 2026
@bsipocz bsipocz merged commit ee00587 into astropy:main Jun 9, 2026
12 of 15 checks passed
@bsipocz

bsipocz commented Jun 9, 2026

Copy link
Copy Markdown
Member

@tomdonaldson @fjebaker - what do you think about the cli suggestion above?

@fjebaker

fjebaker commented Jun 9, 2026

Copy link
Copy Markdown
Member

I think it's a good idea! I think it fits in naturally with other Python module tools like python3 -m http.server.

P.S.: I am still planning to submit some SAMP patches, but unfortunately after my migration PR got merged I've struggled to find the time to work on them... :(

@bsipocz

bsipocz commented Jun 9, 2026

Copy link
Copy Markdown
Member

P.S.: I am still planning to submit some SAMP patches, but unfortunately after my migration PR got merged I've struggled to find the time to work on them... :(

No worries, you get to it when you get to it, any attention to samp on any timescale will be better than we had for it in the past many years

@bsipocz

bsipocz commented Jun 9, 2026

Copy link
Copy Markdown
Member

I think it's a good idea! I think it fits in naturally with other Python module tools like python3 -m http.server.

OK. If the other maintainers are OK with it, then I can tag a new 1.9.1 release once this change is done.

@pllim pllim deleted the astropy-samp-fix branch June 9, 2026 14:22
@pllim pllim mentioned this pull request Jun 9, 2026
@pllim

pllim commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

I opened #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants