Fixes for SAMP migration from astropy to pyvo#762
Conversation
to not point to upstream deprecated command
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 79.88% 79.88%
=======================================
Files 91 91
Lines 10312 10312
=======================================
Hits 8238 8238
Misses 2074 2074 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I will add a change log if you think we need it. @astrofrog also suggested that pyvo removes the samp_hub CLI completely, so if you want to go with that instead, then this PR needs to be modified. |
|
Just to expand on my suggestion, we could move to a model where we no longer have a CLI command but set it up so that users can instead do e.g.: |
| [options.entry_points] | ||
| console_scripts = | ||
| samp_hub = astropy.samp.hub_script:hub_script | ||
| samp_hub = pyvo.samp.hub_script:hub_script |
There was a problem hiding this comment.
🤦♀️ of not noticing this in review.
|
@tomdonaldson @fjebaker - what do you think about the cli suggestion above? |
|
I think it's a good idea! I think it fits in naturally with other Python module tools like P.S.: I am still planning to submit some SAMP patches, but unfortunately after my migration PR got merged I've struggled to find the time to work on them... :( |
No worries, you get to it when you get to it, any attention to samp on any timescale will be better than we had for it in the past many years |
OK. If the other maintainers are OK with it, then I can tag a new 1.9.1 release once this change is done. |
|
I opened #763 |
This is a follow-up of #729
Related issue: #761