Skip to content

Conversation

@s-katte
Copy link
Member

@s-katte s-katte commented Oct 1, 2020

solves #19

@s-katte s-katte requested a review from gridhead October 7, 2020 06:12
Copy link
Member

@VaibhavSaini19 VaibhavSaini19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-katte

  • I think you created a branch from master and made changes in that. As asked by @t0xic0der , the desired changes are to be made in modern-layout branch. Also, remove unnecessary indentation in the code that you modified.
  • The JS you added was not inside <script> tags, so it wouldn't work anyway.
  • If @t0xic0der approves, you can also toggle the icons easily with the following code, assuming you call this function on icon click, instead of creating 2 separate functions:
function toggle(){
    let isTypePwd = document.getElementById("pwd").type == "password";
    document.getElementById("pwd").type = isTypePwd ? "text" : "password";
    document.getElementById("eyeSlash").style.display = isTypePwd ? "block" : "none";
    document.getElementById("eye").style.display = isTypePwd ? "none" : "block";
  }

@s-katte
Copy link
Member Author

s-katte commented Oct 7, 2020

sure, I will do the it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants