Skip to content

Conversation

@resparx
Copy link

@resparx resparx commented Sep 25, 2020

add fav icon to index.html

solves issue #13

@gridhead gridhead self-requested a review September 26, 2020 01:23
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @resparx, thank you for your contributions.

As much as I appreciate your contributions - I do remark that you should have assigned yourself the issue first by commenting under the issue and then, you should have started the work on it. I would now suggest you to make conversation with the current assignee of #8 under the issue to see if they are okay with relinquishing their assignment because your work is done.

Once they leave the assignment, I would assign that to you and then, begin with reviewing your pull request. Not before that. Happy hacking! 😄

@resparx
Copy link
Author

resparx commented Sep 26, 2020

Hey hi, I missed the issue #8 , i just came across the issue #13 , so i gave the PR .I didn't notice there is a duplicate in issue 😄

@gridhead
Copy link
Member

I am afraid #13 is a pull request and not an issue.

We could not afford to have mistakes setting issues and labelling them when it comes to hacktoberfest. Do not worry, we have taken care of all norms we are supposed to. There are a plethora of other issues available in the repositories of the AstroSonic organization that you can ask assignment for.

Thank you.

@gridhead gridhead mentioned this pull request Sep 26, 2020
@gridhead gridhead added the invalid This doesn't seem right label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants