added multiple expression support for @bs macro, removed @bcomp. added common histogram axis. Fixes #8#7
Open
ajinkya-k wants to merge 7 commits intoastrozot:mainfrom
Open
Conversation
Contributor
Author
|
@astrozot There is one issue that I could not figure out how to solve: I am using |
Owner
|
Hi @ajinkya-k , thank you, I will take care of it. |
@bcomp macro
Contributor
Author
|
@astrozot @LilithHafner can you try this out and see if you can find any edge cases or issues? |
Contributor
Author
|
@astrozot does something else need to be done to merge this? |
@bs macro, removed @bcomp. added common histogram axis. Fixes #8
Contributor
Author
|
hey @astrozot did you get a chance to see this PR? |
Owner
|
Hi @ajinkya-k , sorry for the delay, but I am quite busy in this period and did not have a chance to check your code. Will try to do it soon. |
Contributor
Author
|
@astrozot No worries. Sorry to bother you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Base.showmethod for comparative benchmarking using@bcompto display histograms with a common x-axis, making them histograms directly comparable. Also fixes #8