Feature (Home): Sort Section List Items by Distance to User#467
Open
ananyadua27 wants to merge 3 commits intomasterfrom
Open
Feature (Home): Sort Section List Items by Distance to User#467ananyadua27 wants to merge 3 commits intomasterfrom
ananyadua27 wants to merge 3 commits intomasterfrom
Conversation
ananyadua27
changed the title
justinwongeecs
requested changes
Nov 5, 2025
Comment on lines
+19
to
+21
| // Sort items by proximity to user (ascending) | ||
| // utilizes the CLLocation.distanceFromUser() helper | ||
| // items without lat/lon sent to the bottom |
Comment on lines
+61
to
+62
| // items -> sortedItems in both forEach calls | ||
| // displays all items as tappable rows |
Comment on lines
+58
to
+72
| }) { | ||
| } label: { |
Collaborator
There was a problem hiding this comment.
for buttons, we typically do something like this:
Button (action: {
}) {
}What you have is valid, but since label is the last parameter and it is a closure, we can use the trailing closure syntax: https://www.hackingwithswift.com/sixty/6/5/trailing-closure-syntax
|
|
||
| BMHomeSectionListView(sectionType: .dining, items: diningHalls, mapViewController: MapViewController()) | ||
| } | ||
|
|
Collaborator
Author
|
All requested changes have been addressed. Ready for final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Testing steps
Resolves #436