Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sorting feature to the list view on the Home screen. Users can now choose how they want the list to be sorted. A new reusable sort menu component was added so this feature can be used later within the app.
Changes included
Added a reusable sort menu view (BMSortMenuView)
Added a reusable sorting option enum (BMSortOption)
Added a generic sorting engine (BMSortEngine)
Updated BMHomeSectionListView to support sorting
Added a sort button above the list
Sorting modes:
1. Name (A to Z)
2. Name (Z to A)
3. Closest
4. Furthest
5. Open Times
6. Close Times
Updated the Home section list (dining, fitness and study) to use a generic type that works with the sort engine
Note: Since we do not display open/close for fitness/study, for now the sort has only 4 options (all but open/close).
Once we're able to integrate that, we can add the last 2 sort options in as well
Maintained existing iOS version behavior
Testing
Linked Issue
Closes #459