Convert ResourcesViewModel To Use Observation#557
Open
megangadiparthy wants to merge 1 commit into
Open
Conversation
justinwongeecs
requested changes
Apr 5, 2026
justinwongeecs
left a comment
justinwongeecs
left a comment
Collaborator
There was a problem hiding this comment.
We shouldn't check in GoogleService-Info.plist and Secrets.swift. Also I don't think I see any changes checked in for ResourcesViewModel.swift?
Collaborator
There was a problem hiding this comment.
We shouldn't check this file into git.
You can remove this file from being tracked by git by I believe via the git restore [PATH TO FILE] command.
Collaborator
There was a problem hiding this comment.
We shouldn't check in this file as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ResourcesViewModel uses the ObservableObject paradigm. We should convert the view model to use the Observation framework introduced since iOS 17.