Testcase for processor import check - #54
Open
jzpang wants to merge 5 commits into
Open
Conversation
hunterhector
left a comment
hunterhector
left a comment
Member
There was a problem hiding this comment.
When I ask about the import check, it was on the composable system module (https://github.com/petuum/composing_information_system)
We need to maintain the wrapper repo as a higher standard. We need to write a bit more than just import. Can you add simple running examples here?
btw, what is the my_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #53.
Description of changes
testcase added for
elastic_search_index_processor.py
elastic_search_processor.py
elastic_search_query_creator.py
twittersearch_processor.py
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Describe what test cases are included for the PR.