accept no-voting node #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config.go
There was a problem hiding this comment.
Hey, thanks for the PR. In theory this sounds perfectly fine, I would just have to double check that it doesn't mess with any logic that might be expecting a vote address for every validator identity.
Additionally, if you just set all voteKeys = []string{}, then this is probably not the desired behaviour for someone who configures their validator to watch some voting nodes and some non-voting nodes.
But regardless, thanks again for the PR - I will look into this further and either approve or request changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here should not be mandatory
if votekey cannot find we should not take it as a panic error