Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with cross-module assert handling in the Move prover by ensuring assert functions are properly processed when called from different modules.
- Adds a new condition to handle asserts calls in Default translation style
- Updates test case to verify cross-module assert functionality works correctly
- Includes a minor formatting adjustment to improve code readability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/sui-prover/tests/inputs/assert.ok.move | Adds test case demonstrating cross-module assert usage with prover spec |
| crates/sui-prover/tests/snapshots/assert.ok.move.snap | Expected test output snapshot showing successful verification |
| crates/move-prover-boogie-backend/src/boogie_backend/bytecode_translator.rs | Fixes assert processing logic and minor formatting cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
@andrii-a8c I think we can revert the code change, just keep the tests |
Fixes #147
Note
Adds tests verifying cross-module asserts succeed in targeted specs and that asserts in scenario specs produce the expected error.
tests/inputs/assert.ok.movetargeting0x42::foo::foofrom0x43::bar::foo_spec; snapshotsnapshots/assert.ok.move.snapexpects "Verification successful".tests/inputs/assert.scenario.fail.movewithscenario_specusingasserts; snapshotsnapshots/assert.scenario.fail.move.snapexpects bytecode transformation error about scenario specs and asserts.Written by Cursor Bugbot for commit b5c8fb2. This will update automatically on new commits. Configure here.