feat: x-linkedin extension support#1155
feat: x-linkedin extension support#1155catosaurusrex2003 wants to merge 4 commits intoasyncapi:masterfrom
Conversation
catosaurusrex2003
requested review from
AceTheCreator,
asyncapi-bot-eve,
fmvilas and
magicmatatjahu
as code owners
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
still relevant |
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
| "build:types": "tsc -p tsconfig.types.json", | ||
| "build:styles": "npm run build:styles:dev && npm run build:styles:prod", | ||
| "build:styles:dev": "cross-env NODE_ENV=production postcss src/styles/default.css -o styles/default.css --verbose", | ||
| "build:styles:dev": "cross-env NODE_ENV=development postcss src/styles/default.css -o styles/default.css --verbose & cross-env NODE_ENV=development postcss src/styles/default.css -o styles/default.min.css --verbose", |
There was a problem hiding this comment.
@catosaurusrex2003 remind me again why we are doing this?
There was a problem hiding this comment.
To prevent tree-shaking.
Making the NODE_ENV as development bundles styles which we are not even using in the project.
This enables us to use (never used before) classnames in development, without needing to build the styles again and again.
AceTheCreator
left a comment
AceTheCreator
left a comment
There was a problem hiding this comment.
Left you some review @catosaurusrex2003
| parent={item} | ||
| /> | ||
| ); | ||
| } else return null; |
There was a problem hiding this comment.
@catosaurusrex2003 I'm curious about the approach here, what's the advantage of returning null instead of using an else statement? Why is handling it in a single iteration better than separating the logic as you did in this PR?
|
2 participants
Description
support for x-linkedin extension: https://github.com/asyncapi/extensions-catalog/blob/master/extensions/linkedin.md
just like how this was implemented #994
Related issue(s)
None